• This project
    • Loading...
  • Sign in

Ruby Gems / var

Elementos brand ukko 05 cropped
Go to a project
Toggle navigation Toggle navigation pinning
  • Projects
  • Groups
  • Snippets
  • Help
  • Project
  • Activity
  • Repository
  • Pipelines
  • Graphs
  • Issues 0
  • Merge Requests 0
  • Wiki
  • Snippets
  • Network
  • Create a new issue
  • Builds
  • Commits
  • Issue Boards
Merged
Merge Request !3 opened 2016-06-22 22:28:42 UTC by Ricardo Garcia@rgp

Pulled info from webhook such as amount_paid, paid_at, payment_fee and payment_method

Edited 2016-06-22 23:30:29 UTC
Request to merge upgrade/payment_info_attr into master
×

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b upgrade/payment_info_attr origin/upgrade/payment_info_attr

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git checkout master
git merge --no-ff upgrade/payment_info_attr

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

CI build passed for 2e9dd7e8.
CI build skipped for 2e9dd7e8.
CI build canceled for 2e9dd7e8.
CI build failed for 2e9dd7e8.
CI build running for 2e9dd7e8.
CI build pending for 2e9dd7e8.
Checking CI status for 2e9dd7e8…
Could not find CI status for 2e9dd7e8.
Could not connect to the CI server. Please check your settings and try again.

Merged

The changes were merged into master. The source branch has been removed.

  • Discussion 1
  • Commits 4
  • Changes 2
  • {{ resolvedDiscussionCount }}/{{ discussionCount }} {{ discussionCount | pluralize 'discussion' }} resolved
  • Avatar
    Toggle discussion
    Ricardo Garcia
    @rgp started a discussion on an outdated diff 2016-06-22 22:30:44 UTC
    lib/var.rb
    30 30 def self.conekta_webhook(params)
    31 31 payment = params[:data][:object]
    32 32 object = Var.find_charge payment[:id]
    33 object.update_columns(var_status: payment[:status])
    34 object.update_columns(var_payment_at: Time.zone.now) if object.var_payed?
    33 case payment[:payment_method][:object]
    34 when "bank_transfer_payment"
    35 object.update_columns(var_payment_method: "Transferencia bancaria")
    • Ricardo Garcia
      @rgp commented 2016-06-22 22:30:44 UTC
      Owner

      object.update_columns(var_payment_method: "Transferencia bancaria")

      Este pedo cambialo a ingles y snake

      object.update_columns(var_payment_method: "bank_transfer_payment")

      En los casos de oxxo y demás checa el tipo que está utilizando VAR para que ese mismo se utilice

  • Marcelo
    @m.salcedo 2016-06-22 22:47:55 UTC

    Added 1 commit:

    • a6ab1636 - Deleted case for type of payment
  • Marcelo
    @m.salcedo 2016-06-22 23:15:56 UTC

    Added 1 commit:

    • b461eb60 - Parsed unix timestamp to timestamp
  • Ricardo Garcia
    @rgp 2016-06-22 23:29:41 UTC

    Added 1 commit:

    • 2e9dd7e8 - Print exception in case
  • Ricardo Garcia
    @rgp 2016-06-22 23:30:26 UTC

    mentioned in commit bcca69e4

  • Ricardo Garcia
    @rgp 2016-06-22 23:30:29 UTC

    Status changed to merged

  • Please register or login to post a comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
2
2 participants
Reference: gems/var!3